Building Arm Images #5041

alanprot · 2022-12-14T04:55:48Z

What this PR does:
Build ARM Images ARM Images:

The image was tested on an AWS Graviton Instance:

IMAGE Example:

quay.io/cortexproject/cortex:HEAD-efbbb29
cortexproject/cortex:HEAD-efbbb29

Output:

docker run quay.io/cortexproject/cortex:HEAD-efbbb29
level=info ts=2022-12-15T02:23:42.704220664Z caller=main.go:194 msg="Starting Cortex" version="(version=1.14.0, branch=HEAD, revision=9be1ec5)"
level=info ts=2022-12-15T02:23:42.704821947Z caller=server.go:306 http=[::]:80 grpc=[::]:9095 msg="server listening on addresses"
level=error ts=2022-12-15T02:23:42.705918487Z caller=log.go:117 msg="error running cortex" err="no s3 endpoint in config file\ngithub.com/thanos-io/objstore/providers/s3.validate\n\t/__w/cortex/cortex/vendor/github.com/thanos-io/objstore/providers/s3/s3.go:348\ngithub.com/thanos-io/objstore/providers/s3.NewBucketWithConfig\n\t/__w/cortex/cortex/vendor/github.com/thanos-io/objstore/providers/s3/s3.go:219\ngithub.com/cortexproject/cortex/pkg/storage/bucket/s3.NewBucketClient\n\t/__w/cortex/cortex/pkg/storage/bucket/s3/bucket_client.go:17\ngithub.com/cortexproject/cortex/pkg/storage/bucket.NewClient\n\t/__w/cortex/cortex/pkg/storage/bucket/client.go:102\ngithub.com/cortexproject/cortex/pkg/ingester.New\n\t/__w/cortex/cortex/pkg/ingester/ingester.go:603\ngithub.com/cortexproject/cortex/pkg/cortex.(*Cortex).initIngesterService\n\t/__w/cortex/cortex/pkg/cortex/modules.go:400\ngithub.com/cortexproject/cortex/pkg/util/modules.(*Manager).initModule\n\t/__w/cortex/cortex/pkg/util/modules/modules.go:106\ngithub.com/cortexproject/cortex/pkg/util/modules.(*Manager).InitModuleServices\n\t/__w/cortex/cortex/pkg/util/modules/modules.go:78\ngithub.com/cortexproject/cortex/pkg/cortex.(*Cortex).Run\n\t/__w/cortex/cortex/pkg/cortex/cortex.go:398\nmain.main\n\t/__w/cortex/cortex/cmd/cortex/main.go:196\nruntime.main\n\t/usr/local/go/src/runtime/proc.go:250\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_arm64.s:1172\nfailed to create the bucket client\ngithub.com/cortexproject/cortex/pkg/ingester.New\n\t/__w/cortex/cortex/pkg/ingester/ingester.go:605\ngithub.com/cortexproject/cortex/pkg/cortex.(*Cortex).initIngesterService\n\t/__w/cortex/cortex/pkg/cortex/modules.go:400\ngithub.com/cortexproject/cortex/pkg/util/modules.(*Manager).initModule\n\t/__w/cortex/cortex/pkg/util/modules/modules.go:106\ngithub.com/cortexproject/cortex/pkg/util/modules.(*Manager).InitModuleServices\n\t/__w/cortex/cortex/pkg/util/modules/modules.go:78\ngithub.com/cortexproject/cortex/pkg/cortex.(*Cortex).Run\n\t/__w/cortex/cortex/pkg/cortex/cortex.go:398\nmain.main\n\t/__w/cortex/cortex/cmd/cortex/main.go:196\nruntime.main\n\t/usr/local/go/src/runtime/proc.go:250\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_arm64.s:1172\nerror initialising module: ingester-service\ngithub.com/cortexproject/cortex/pkg/util/modules.(*Manager).initModule\n\t/__w/cortex/cortex/pkg/util/modules/modules.go:108\ngithub.com/cortexproject/cortex/pkg/util/modules.(*Manager).InitModuleServices\n\t/__w/cortex/cortex/pkg/util/modules/modules.go:78\ngithub.com/cortexproject/cortex/pkg/cortex.(*Cortex).Run\n\t/__w/cortex/cortex/pkg/cortex/cortex.go:398\nmain.main\n\t/__w/cortex/cortex/cmd/cortex/main.go:196\nruntime.main\n\t/usr/local/go/src/runtime/proc.go:250\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_arm64.s:1172"

Which issue(s) this PR fixes:
Fixes: #4733 #4728

Checklist

[NA] Tests updated
[NA] Documentation added
CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Alan Protasio <approtas@amazon.com>

yeya24

Great work 🔥

* wip Signed-off-by: Alan Protasio <approtas@amazon.com> * est Signed-off-by: Alan Protasio <approtas@amazon.com> * quay Signed-off-by: Alan Protasio <approtas@amazon.com> * using different repository for the archteture specific images Signed-off-by: Alan Protasio <approtas@amazon.com> * testing linux repos Signed-off-by: Alan Protasio <approtas@amazon.com> * testing manifes on both platforms Signed-off-by: Alan Protasio <approtas@amazon.com> * enabling deploy stage only on master Signed-off-by: Alan Protasio <approtas@amazon.com> * changelog Signed-off-by: Alan Protasio <approtas@amazon.com> * using amd64 image for e2e teests Signed-off-by: Alan Protasio <approtas@amazon.com> Signed-off-by: Alan Protasio <approtas@amazon.com>

* wip Signed-off-by: Alan Protasio <approtas@amazon.com> * est Signed-off-by: Alan Protasio <approtas@amazon.com> * quay Signed-off-by: Alan Protasio <approtas@amazon.com> * using different repository for the archteture specific images Signed-off-by: Alan Protasio <approtas@amazon.com> * testing linux repos Signed-off-by: Alan Protasio <approtas@amazon.com> * testing manifes on both platforms Signed-off-by: Alan Protasio <approtas@amazon.com> * enabling deploy stage only on master Signed-off-by: Alan Protasio <approtas@amazon.com> * changelog Signed-off-by: Alan Protasio <approtas@amazon.com> * using amd64 image for e2e teests Signed-off-by: Alan Protasio <approtas@amazon.com> Signed-off-by: Alan Protasio <approtas@amazon.com> Signed-off-by: Alan Protasio <alanprot@gmail.com>

* wip Signed-off-by: Alan Protasio <approtas@amazon.com> * est Signed-off-by: Alan Protasio <approtas@amazon.com> * quay Signed-off-by: Alan Protasio <approtas@amazon.com> * using different repository for the archteture specific images Signed-off-by: Alan Protasio <approtas@amazon.com> * testing linux repos Signed-off-by: Alan Protasio <approtas@amazon.com> * testing manifes on both platforms Signed-off-by: Alan Protasio <approtas@amazon.com> * enabling deploy stage only on master Signed-off-by: Alan Protasio <approtas@amazon.com> * changelog Signed-off-by: Alan Protasio <approtas@amazon.com> * using amd64 image for e2e teests Signed-off-by: Alan Protasio <approtas@amazon.com> Signed-off-by: Alan Protasio <approtas@amazon.com>

* wip Signed-off-by: Alan Protasio <approtas@amazon.com> * est Signed-off-by: Alan Protasio <approtas@amazon.com> * quay Signed-off-by: Alan Protasio <approtas@amazon.com> * using different repository for the archteture specific images Signed-off-by: Alan Protasio <approtas@amazon.com> * testing linux repos Signed-off-by: Alan Protasio <approtas@amazon.com> * testing manifes on both platforms Signed-off-by: Alan Protasio <approtas@amazon.com> * enabling deploy stage only on master Signed-off-by: Alan Protasio <approtas@amazon.com> * changelog Signed-off-by: Alan Protasio <approtas@amazon.com> * using amd64 image for e2e teests Signed-off-by: Alan Protasio <approtas@amazon.com> Signed-off-by: Alan Protasio <approtas@amazon.com> Signed-off-by: Alan Protasio <alanprot@gmail.com>

rafilkmp3 · 2022-12-26T14:51:44Z

Hi how I can use the new arm images ? I tried to use latest v.1.14 default from helm and only seens to be builded for x86

podman image inspect quay.io/cortexproject/cortex:v1.14.0 | jq -r '.[] | .Architecture'
amd64

alanprot · 2022-12-26T17:14:37Z

It was built only on 1.14.1

This reverts commit f5b08ea.

* wip Signed-off-by: Alan Protasio <approtas@amazon.com> * est Signed-off-by: Alan Protasio <approtas@amazon.com> * quay Signed-off-by: Alan Protasio <approtas@amazon.com> * using different repository for the archteture specific images Signed-off-by: Alan Protasio <approtas@amazon.com> * testing linux repos Signed-off-by: Alan Protasio <approtas@amazon.com> * testing manifes on both platforms Signed-off-by: Alan Protasio <approtas@amazon.com> * enabling deploy stage only on master Signed-off-by: Alan Protasio <approtas@amazon.com> * changelog Signed-off-by: Alan Protasio <approtas@amazon.com> * using amd64 image for e2e teests Signed-off-by: Alan Protasio <approtas@amazon.com> Signed-off-by: Alan Protasio <approtas@amazon.com> Signed-off-by: Alex Le <leqiyue@amazon.com>

pull-request-size bot added the size/M label Dec 14, 2022

alanprot force-pushed the multi-arch branch 17 times, most recently from 757de54 to 8588cc7 Compare December 14, 2022 07:44

alanprot mentioned this pull request Dec 14, 2022

Publish and test arm docker images for every PR #4733

Closed

alanprot force-pushed the multi-arch branch 10 times, most recently from 810d8f3 to 2ad390d Compare December 15, 2022 02:19

wip

93a1803

Signed-off-by: Alan Protasio <approtas@amazon.com>

alanprot added 7 commits December 14, 2022 18:25

est

25f3753

Signed-off-by: Alan Protasio <approtas@amazon.com>

quay

38b956a

Signed-off-by: Alan Protasio <approtas@amazon.com>

using different repository for the archteture specific images

c94b194

Signed-off-by: Alan Protasio <approtas@amazon.com>

testing linux repos

ba1b32c

Signed-off-by: Alan Protasio <approtas@amazon.com>

testing manifes on both platforms

4d51573

Signed-off-by: Alan Protasio <approtas@amazon.com>

enabling deploy stage only on master

8a8cf04

Signed-off-by: Alan Protasio <approtas@amazon.com>

changelog

e612356

Signed-off-by: Alan Protasio <approtas@amazon.com>

alanprot force-pushed the multi-arch branch from 2ad390d to e612356 Compare December 15, 2022 02:30

alanprot marked this pull request as ready for review December 15, 2022 02:32

alanprot requested review from friedrichg and yeya24 December 15, 2022 02:34

using amd64 image for e2e teests

f50ac38

Signed-off-by: Alan Protasio <approtas@amazon.com>

yeya24 approved these changes Dec 15, 2022

View reviewed changes

alanprot merged commit f5b08ea into master Dec 15, 2022

alanprot deleted the multi-arch branch December 15, 2022 16:34

soonping-amzn added a commit to soonping-amzn/cortex-soonping-amzn that referenced this pull request Feb 24, 2023

Revert "Building Arm Images (cortexproject#5041)"

67741fd

This reverts commit f5b08ea.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Building Arm Images #5041

Building Arm Images #5041

alanprot commented Dec 14, 2022 •

edited

yeya24 left a comment

rafilkmp3 commented Dec 26, 2022

alanprot commented Dec 26, 2022

Building Arm Images #5041

Building Arm Images #5041

Conversation

alanprot commented Dec 14, 2022 • edited

yeya24 left a comment

Choose a reason for hiding this comment

rafilkmp3 commented Dec 26, 2022

alanprot commented Dec 26, 2022

alanprot commented Dec 14, 2022 •

edited