New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tracing.NewRandomRatioBased panic #5044
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alan Protasio <approtas@amazon.com>
alanprot
force-pushed
the
fix-xray-sampler
branch
from
December 15, 2022 21:31
13735fa
to
323f3c8
Compare
Signed-off-by: Alan Protasio <approtas@amazon.com>
yeya24
reviewed
Dec 15, 2022
Signed-off-by: Alan Protasio <approtas@amazon.com>
Signed-off-by: Alan Protasio <approtas@amazon.com>
yeya24
approved these changes
Dec 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I created a PR on the otel contrib: open-telemetry/opentelemetry-go-contrib#3090 Lets see if get merged. |
alanprot
added a commit
that referenced
this pull request
Dec 18, 2022
* fix NewRandomRatioBased panic Signed-off-by: Alan Protasio <approtas@amazon.com> * changelog Signed-off-by: Alan Protasio <approtas@amazon.com> * make lint happy Signed-off-by: Alan Protasio <approtas@amazon.com> * adding back xray propagator Signed-off-by: Alan Protasio <approtas@amazon.com> * rename the sampler Signed-off-by: Alan Protasio <approtas@amazon.com> Signed-off-by: Alan Protasio <approtas@amazon.com>
alanprot
added a commit
that referenced
this pull request
Dec 18, 2022
* fix NewRandomRatioBased panic Signed-off-by: Alan Protasio <approtas@amazon.com> * changelog Signed-off-by: Alan Protasio <approtas@amazon.com> * make lint happy Signed-off-by: Alan Protasio <approtas@amazon.com> * adding back xray propagator Signed-off-by: Alan Protasio <approtas@amazon.com> * rename the sampler Signed-off-by: Alan Protasio <approtas@amazon.com> Signed-off-by: Alan Protasio <approtas@amazon.com> Signed-off-by: Alan Protasio <alanprot@gmail.com>
alanprot
added a commit
that referenced
this pull request
Dec 18, 2022
* fix NewRandomRatioBased panic Signed-off-by: Alan Protasio <approtas@amazon.com> * changelog Signed-off-by: Alan Protasio <approtas@amazon.com> * make lint happy Signed-off-by: Alan Protasio <approtas@amazon.com> * adding back xray propagator Signed-off-by: Alan Protasio <approtas@amazon.com> * rename the sampler Signed-off-by: Alan Protasio <approtas@amazon.com> Signed-off-by: Alan Protasio <approtas@amazon.com>
alanprot
added a commit
that referenced
this pull request
Dec 18, 2022
* fix NewRandomRatioBased panic Signed-off-by: Alan Protasio <approtas@amazon.com> * changelog Signed-off-by: Alan Protasio <approtas@amazon.com> * make lint happy Signed-off-by: Alan Protasio <approtas@amazon.com> * adding back xray propagator Signed-off-by: Alan Protasio <approtas@amazon.com> * rename the sampler Signed-off-by: Alan Protasio <approtas@amazon.com> Signed-off-by: Alan Protasio <approtas@amazon.com> Signed-off-by: Alan Protasio <alanprot@gmail.com>
alexqyle
pushed a commit
to alexqyle/cortex
that referenced
this pull request
May 2, 2023
* fix NewRandomRatioBased panic Signed-off-by: Alan Protasio <approtas@amazon.com> * changelog Signed-off-by: Alan Protasio <approtas@amazon.com> * make lint happy Signed-off-by: Alan Protasio <approtas@amazon.com> * adding back xray propagator Signed-off-by: Alan Protasio <approtas@amazon.com> * rename the sampler Signed-off-by: Alan Protasio <approtas@amazon.com> Signed-off-by: Alan Protasio <approtas@amazon.com> Signed-off-by: Alex Le <leqiyue@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Fix the NewRandomRatioBased panic.
This sampler were using a random - which is not thread safe:
This PR change the sample decision to be based on the random part of the trace Id.
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]