Fixed no compact block got grouped in shuffle sharding grouper #5055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Le <leqiyue@amazon.com>
yeya24
approved these changes
Dec 19, 2022
yeya24
reviewed
Dec 19, 2022
| metrics: `# HELP cortex_compactor_remaining_planned_compactions Total number of plans that remain to be compacted. | ||
| # TYPE cortex_compactor_remaining_planned_compactions gauge | ||
| cortex_compactor_remaining_planned_compactions 2 | ||
| `, |
There was a problem hiding this comment.
We should really improve such test cases, like using CollectAndCompare is better IMHO.
This is just a note, we don't need to do anything in this pr. Let me create an issue to track it.
Signed-off-by: Alex Le <leqiyue@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Le leqiyue@amazon.com
What this PR does:
Fixed no compact block got grouped in shuffle sharding grouper which caused blocks with no compact marker were always grouped and tried to be compacted. With concurrency set to 1, this would prevent new blocks got compacted.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]