Support Zstd compression for gRPC #5092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sesha Sendhil <seshasendhil@gmail.com>
Signed-off-by: Sesha Sendhil <seshasendhil@gmail.com>
Signed-off-by: Sesha Sendhil <seshasendhil@gmail.com>
alanprot
previously approved these changes
Jan 12, 2023
|
This looks good! Can you update the changelog? |
Signed-off-by: Sesha Sendhil <seshasendhil@gmail.com>
|
Thanks @alanprot . Have updated the changelog |
alanprot
approved these changes
Jan 12, 2023
|
LGTM |
yeya24
approved these changes
Jan 12, 2023
CHANGELOG.md
Outdated
| @@ -11,6 +11,7 @@ | |||
| * [ENHANCEMENT] Query Frontend: Log Vertical sharding information when `query_stats_enabled` is enabled. #5037 | |||
| * [ENHANCEMENT] Ingester: The metadata APIs should honour `querier.query-ingesters-within` when `querier.query-store-for-labels-enabled` is true. #5027 | |||
| * [ENHANCEMENT] Query Frontend: Skip instant query roundtripper if sharding is not applicable. #5062 | |||
| * [ENHANCEMENT] Added zstd as an option for grpc compression #5092 | |||
There was a problem hiding this comment.
Let's call it FEATURE instead?
Signed-off-by: Sesha Sendhil <seshasendhil@gmail.com>
yeya24
approved these changes
Jan 12, 2023
alexqyle
pushed a commit
to alexqyle/cortex
that referenced
this pull request
May 2, 2023
* add zstd compression to grpcclient Signed-off-by: Sesha Sendhil <seshasendhil@gmail.com> * fix use of deprecated ioutil pkg Signed-off-by: Sesha Sendhil <seshasendhil@gmail.com> * update docs Signed-off-by: Sesha Sendhil <seshasendhil@gmail.com> * update CHANGELOG Signed-off-by: Sesha Sendhil <seshasendhil@gmail.com> * mark as feature Signed-off-by: Sesha Sendhil <seshasendhil@gmail.com> Signed-off-by: Sesha Sendhil <seshasendhil@gmail.com> Signed-off-by: Alex Le <leqiyue@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Add zstd compression for grpc
Below output with zstd level BetterCompression as here
We see
Which issue(s) this PR fixes:
Fixes #5091
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]