Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new thanos promql engine #5093

Merged
merged 4 commits into from
Jan 12, 2023

Conversation

yeya24
Copy link
Collaborator

@yeya24 yeya24 commented Jan 11, 2023

Signed-off-by: Ben Ye benye@amazon.com

What this PR does:

This pr allows to user to use the experimental Thanos promql engine.

PromQL Query Engine
A multi-threaded implementation of a PromQL Query Engine based on the Volcano/Iterator model.

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@yeya24 yeya24 marked this pull request as draft January 11, 2023 19:48
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jan 12, 2023
@yeya24 yeya24 force-pushed the thanos-engine branch 3 times, most recently from 32eb0d7 to 971f4cc Compare January 12, 2023 07:45
Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com>
@yeya24 yeya24 marked this pull request as ready for review January 12, 2023 18:06
@alanprot
Copy link
Member

That's awesome! Thanks a lot for this!

Signed-off-by: Ben Ye <benye@amazon.com>
@yeya24 yeya24 merged commit c9b0156 into cortexproject:master Jan 12, 2023
@yeya24 yeya24 deleted the thanos-engine branch January 12, 2023 21:44
alexqyle pushed a commit to alexqyle/cortex that referenced this pull request May 2, 2023
* add support for new thanos promql engine

Signed-off-by: Ben Ye <benye@amazon.com>

* add some e2e tests

Signed-off-by: Ben Ye <benye@amazon.com>

* update changelog

Signed-off-by: Ben Ye <benye@amazon.com>

* add more tests in ut

Signed-off-by: Ben Ye <benye@amazon.com>

Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Alex Le <leqiyue@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants