Change log level for 4xx on Push API. Do not log on 429 #5103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Deluiggi <ddeluigg@amazon.com>
Signed-off-by: Daniel Deluiggi <ddeluigg@amazon.com>
danielblando
force-pushed
the
cleanLogs
branch
from
040bfe2
to
55c9d4e
Compare
Signed-off-by: Daniel Deluiggi <ddeluigg@amazon.com>
danielblando
changed the title
danielblando
changed the title
yeya24
approved these changes
Jan 26, 2023
friedrichg
approved these changes
Jan 26, 2023
alexqyle
pushed a commit
to alexqyle/cortex
that referenced
this pull request
May 2, 2023
…t#5103) * Remove error logs in case API returns 4xx Signed-off-by: Daniel Deluiggi <ddeluigg@amazon.com> * Update chnagelog Signed-off-by: Daniel Deluiggi <ddeluigg@amazon.com> * Change to just not log in 429 Signed-off-by: Daniel Deluiggi <ddeluigg@amazon.com> Signed-off-by: Daniel Deluiggi <ddeluigg@amazon.com> Signed-off-by: Alex Le <leqiyue@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Deluiggi ddeluigg@amazon.com
What this PR does:
Change the log level from returns of Push API. 5xx still logs error and now 4xx logs warn. Do not log on 429 status to avoid overloading the service
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]