Retry logic for S3 bucket client #5135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… handling Signed-off-by: Alex Le <leqiyue@amazon.com>
Signed-off-by: Alex Le <leqiyue@amazon.com>
Signed-off-by: Alex Le <leqiyue@amazon.com>
Signed-off-by: Alex Le <leqiyue@amazon.com>
Signed-off-by: Alex Le <leqiyue@amazon.com>
Signed-off-by: Alex Le <leqiyue@amazon.com>
Signed-off-by: Alex Le <leqiyue@amazon.com>
alanprot
reviewed
Feb 23, 2023
yeya24
reviewed
Feb 23, 2023
Signed-off-by: Alex Le <leqiyue@amazon.com>
Signed-off-by: Alex Le <leqiyue@amazon.com>
alexqyle
changed the title
Signed-off-by: Alex Le <leqiyue@amazon.com>
yeya24
approved these changes
Feb 28, 2023
Signed-off-by: Alex Le <leqiyue@amazon.com>
Signed-off-by: Alex Le <leqiyue@amazon.com>
Signed-off-by: Alex Le <leqiyue@amazon.com>
alexqyle
added a commit
to alexqyle/cortex
that referenced
this pull request
May 2, 2023
* Added retry logic for S3 bucket client and updated visit marker error handling Signed-off-by: Alex Le <leqiyue@amazon.com> * Updated CHANGELOG Signed-off-by: Alex Le <leqiyue@amazon.com> * Updated docs Signed-off-by: Alex Le <leqiyue@amazon.com> * Changed default max retry Signed-off-by: Alex Le <leqiyue@amazon.com> * Update doc Signed-off-by: Alex Le <leqiyue@amazon.com> * Revert not related bug fix from s3 retry logic change Signed-off-by: Alex Le <leqiyue@amazon.com> * Hard coded S3 retry config Signed-off-by: Alex Le <leqiyue@amazon.com> * Revert unneccessary change Signed-off-by: Alex Le <leqiyue@amazon.com> * clean ws Signed-off-by: Alex Le <leqiyue@amazon.com> * Revised retry config Signed-off-by: Alex Le <leqiyue@amazon.com> * trigger workflow Signed-off-by: Alex Le <leqiyue@amazon.com> * trigger workflow Signed-off-by: Alex Le <leqiyue@amazon.com> --------- Signed-off-by: Alex Le <leqiyue@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]