StoreGateway: Allow filtering out recent blocks during sync #5166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 🌲 Harry 🌊 John 🏔 <johrry@amazon.com>
yeya24
approved these changes
Feb 21, 2023
alanprot
reviewed
Feb 21, 2023
Signed-off-by: 🌲 Harry 🌊 John 🏔 <johrry@amazon.com>
alanprot
approved these changes
Feb 22, 2023
alexqyle
pushed a commit
to alexqyle/cortex
that referenced
this pull request
May 2, 2023
…oject#5166) * Allow filtering out recent blocks during sync Signed-off-by: 🌲 Harry 🌊 John 🏔 <johrry@amazon.com> * Fix build failures and comments Signed-off-by: 🌲 Harry 🌊 John 🏔 <johrry@amazon.com> --------- Signed-off-by: 🌲 Harry 🌊 John 🏔 <johrry@amazon.com> Signed-off-by: Alex Le <leqiyue@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
-blocks-storage.bucket-store.ignore-blocks-withinwhich can be used to ignore recently created blocks from being synced by store-gateways/querier.-querier.query-store-after=24his enabled and set to say 24h, the recently created blocks need not be fetched by store-gateway. In this case turning on this feature by setting-blocks-storage.bucket-store.ignore-blocks-within=23hcan be useful to avoid syncing a lot of the non-compacted blocks.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]