Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fetched samples and chunks count into querier stats #5198

Merged
merged 2 commits into from
Mar 9, 2023

Conversation

yeya24
Copy link
Collaborator

@yeya24 yeya24 commented Mar 7, 2023

What this PR does:

This pr adds support for collecting number of samples and number of chunks fetched at querier and we log the stats at query frontend.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@yeya24 yeya24 marked this pull request as ready for review March 7, 2023 21:00
Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com>
Copy link
Member

@friedrichg friedrichg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alanprot alanprot merged commit 41db460 into cortexproject:master Mar 9, 2023
alexqyle pushed a commit to alexqyle/cortex that referenced this pull request May 2, 2023
…t#5198)

* add fetched samples and chunks count into querier stats

Signed-off-by: Ben Ye <benye@amazon.com>

* update changelog

Signed-off-by: Ben Ye <benye@amazon.com>

---------

Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Alex Le <leqiyue@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants