-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing Snappy Block Encoding #5215
Conversation
5007e4b
to
c1e4045
Compare
@damnever Do you wanna test this change? |
@alanprot Great! I may test this patch next week. |
79c0f24
to
c1bc632
Compare
The results seems pretty good. I dont see any change on the CPU and the network is 10X less. The first deployment of distributors used more CPU because we were changing the len of the dst array to 0, forcing a new array to be allocated on every operation. This was fixed by c1bc632 |
@damnever i addressed your comments... Did you have the chance to test? |
@alanprot You are right, but not in percentage rather CPU usage in seconds. |
Oh i see.. So it reduced the CPU usage in seconds by 45% (22.5*0.65=~14.6)? Nice! |
Nice! This is great improvement. |
Signed-off-by: Alan Protasio <alanprot@gmail.com>
Signed-off-by: Alan Protasio <alanprot@gmail.com>
Signed-off-by: Alan Protasio <alanprot@gmail.com>
Signed-off-by: Alan Protasio <alanprot@gmail.com>
Signed-off-by: Alan Protasio <alanprot@gmail.com>
What this PR does:
This PR is a follow up of #5213 (comment)
This PR is implementing block format snappy encoding:
Benchmark Results:
Comparing Snappy x snappy-block (Decompress)
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]