Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will PRs to support compiling coturn as C++ code instead of C code be accepted? #1389

Open
jonesmz opened this issue Jan 19, 2024 · 1 comment · May be fixed by #1416
Open

Will PRs to support compiling coturn as C++ code instead of C code be accepted? #1389

jonesmz opened this issue Jan 19, 2024 · 1 comment · May be fixed by #1416

Comments

@jonesmz
Copy link
Contributor

jonesmz commented Jan 19, 2024

I wish to use the coturn codebase as a C++ program, as my $dayjob uses it, and has a large (proprietary) C++ codebase that we would integrate some libraries from. E.g. we have an in-house logging library.

I am not proposing to convert coturn into a C++ program. I just want to provide patches that will allow the codebase to be able to compile as C++ without compiler errors. I think this should be possible, as many C code project can be compiled as C++.

Without having dug into this yet, my speculation is that most of the changes necessary will be around pointers, such as adding explicit casts instead of relying on implicit cast from void*.

This would benefit the larger coturn community by allowing other organizations with a similar situation to mine to do the same. E.g. integrate with their own C++ libraries.

@KangLin
Copy link
Contributor

KangLin commented Feb 1, 2024

c is a subset of C++. You don't need to make any changes to use it in C++ projects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants