Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty else branch in ns_turn_server.c #1451

Open
redraincatching opened this issue Mar 12, 2024 · 2 comments
Open

Empty else branch in ns_turn_server.c #1451

redraincatching opened this issue Mar 12, 2024 · 2 comments
Labels

Comments

@redraincatching
Copy link
Contributor

in ns_turn_server.c, around line 4500, there exists this code

  if (sat == HTTP_CLIENT_SOCKET) {

    if (server->verbose) {
      TURN_LOG_FUNC(TURN_LOG_LEVEL_INFO, "%s: HTTP connection input: %s\n", __FUNCTION__,
                    (char *)ioa_network_buffer_data(in_buffer->nbh));
    }

    handle_http_echo(ss->client_socket);

  } else if (sat == HTTPS_CLIENT_SOCKET) {

    //???

  }

is there a reason this else branch has been left empty? and if not, is there a plan to resolve it?

@ggarber
Copy link
Contributor

ggarber commented Mar 31, 2024

TBH I don't know the reason but there is no plan to implement it soon. Is there any use case requiring it?

Thank you for loooking at it.

@redraincatching
Copy link
Contributor Author

@ggarber apologies for the late reply, but i'm not aware of any use cases that require it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants