Skip to content
This repository has been archived by the owner on Dec 13, 2019. It is now read-only.

[node, contracts] Participants list for defining expected order of parties in an app #2007

Open
cf19drofxots opened this issue Jul 25, 2019 · 0 comments
Labels
🐞 Bug 📦 Contracts code related to packages/contracts 📦 Node code related to packages/node
Milestone

Comments

@cf19drofxots
Copy link
Member

Currently when an app is installed, the list of addresses that are used to determine app state and turn number is sorted.

public getSigningKeysFor(addressIndex: number): string[] {
return sortAddresses(
this.userNeuteredExtendedKeys.map(xpub =>
xkeyKthAddress(xpub, addressIndex)
)
);
}

This is an issue because the state of the app might rely on a different ordering of this list.

For example, it's not clear what address the funds are being sent to here:

If a participants list is used, this list will not be sorted and we can define more reasonable expected transitions.

@cf19drofxots cf19drofxots added 📦 Contracts code related to packages/contracts 📦 Node code related to packages/node 🐞 Bug labels Jul 25, 2019
@cf19drofxots cf19drofxots added this to the 👽 Grunty milestone Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 Bug 📦 Contracts code related to packages/contracts 📦 Node code related to packages/node
Projects
None yet
Development

No branches or pull requests

1 participant