Skip to content
This repository has been archived by the owner on Dec 13, 2019. It is now read-only.

[metamask] counterfactual:request:matchmake is responding with JSONAPI payload #2180

Open
joelalejandro opened this issue Aug 14, 2019 · 2 comments

Comments

@joelalejandro
Copy link
Contributor

image

We could probably return the attributes object's content instead of the typical JSONAPI envelope.

@Alonski
Copy link
Member

Alonski commented Aug 14, 2019

@joelalejandro This returns it this way because this was how the dApps were retrieving the data. We would need to fix this in both places :)
BTW should this issue live in the monorepo or in the MM fork?

@joelalejandro
Copy link
Contributor Author

@Alonski Unfortunately, we can't create issues on the MM fork, I think forks aren't allowed to have issues. So I'm putting these here.

And yes, we'd have to fix the dapps as well. :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants