Skip to content
This repository has been archived by the owner on Dec 13, 2019. It is now read-only.

Yarn/node version locking downstream issues #2394

Open
LayneHaber opened this issue Sep 12, 2019 · 4 comments
Open

Yarn/node version locking downstream issues #2394

LayneHaber opened this issue Sep 12, 2019 · 4 comments

Comments

@LayneHaber
Copy link
Collaborator

LayneHaber commented Sep 12, 2019 •
edited

When people install packages that consume counterfactual ones (e.g. some installs @connext/client) using a different yarn or node version, they get the error:

error @counterfactual/node@0.2.65: The engine "yarn" is incompatible with this module. Expected version "1.12.3". Got "1.17.3"
error @counterfactual/node@0.2.65: The engine "node" is incompatible with this module. Expected version "10.15.3". Got "11.10.1"

Should probably unlock the yarn/node versions to eliminate these downstream issues.
@dankins
Copy link

dankins commented Sep 12, 2019

Steps to reproduce in a new directory:

npm init
yarn add @counterfactual/node

This only effects those using yarn, npm install works fine.

dankins pushed a commit to dankins/kirby-web3 that referenced this issue Sep 19, 2019
fix(plugin-connext): remove connext
e8c0e53 
installing the connext client library brings in `@counterfactual/node`, which has very specific `engine` specifications. This breaks `yarn install` for any downstream packages. Removing this dependency until it is fixed upstream
counterfactual/monorepo#2394
@dankins dankins mentioned this issue Sep 19, 2019
Merged
@LayneHaber LayneHaber mentioned this issue Sep 21, 2019
Merged
@ArjunBhuptani
Copy link
Collaborator

@dankins Did this work?^ Will close if so

@ArjunBhuptani
Copy link
Collaborator

Still an issue for people running node v12 (which is a LOT of people). @cf19drofxots any suggestions?

@ArjunBhuptani
Copy link
Collaborator

#2492 Should fix this

@ArjunBhuptani ArjunBhuptani mentioned this issue Oct 20, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dankins @LayneHaber @ArjunBhuptani