Skip to content
This repository has been archived by the owner on Dec 13, 2019. It is now read-only.

Use the same version of Jest across the entire repo #845

Closed
snario opened this issue Feb 26, 2019 · 1 comment · Fixed by #1453
Closed

Use the same version of Jest across the entire repo #845

snario opened this issue Feb 26, 2019 · 1 comment · Fixed by #1453
Labels
🧬 Code Quality

Comments

@snario
Copy link
Contributor

snario commented Feb 26, 2019

dapp-tic-tac-toe requires Jest 23 because react-scripts has not updated yet. See here for more. Since react-scripts has a dependency on an older version, it causes some issues with the monorepo correctly installing both.

To resolve this (and until react-scripts upgrades to Jest 24 we install Jest 23 as default on the majority of packages (so it is hoisted to the root) and Jest 24 only on node and playground because it uses the globalSetup and globalTeardown tranformer functionality released in Jest 24.
@snario snario mentioned this issue Feb 26, 2019
Merged
@snario
Copy link
Contributor Author

snario commented Mar 25, 2019

Now I believe it is @stencil/core that is forcing the dependency on the outdated version of Jest

@snario snario mentioned this issue May 9, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🧬 Code Quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Run yarn upgrade and regenerate yarn.lock counterfactual/monorepo
1 participant
@snario