Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Either get rid of or stabilize HCL repo fork #693

Open
johakoch opened this issue Jan 31, 2023 · 2 comments
Open

Either get rid of or stabilize HCL repo fork #693

johakoch opened this issue Jan 31, 2023 · 2 comments

Comments

@johakoch
Copy link
Collaborator

Couper uses the https://github.com/avenga/hcl fork of https://github.com/hashicorp/hcl.
Either

@johakoch
Copy link
Collaborator Author

johakoch commented Mar 8, 2024

I opened an issue: hashicorp/hcl#666

@johakoch
Copy link
Collaborator Author

johakoch commented Mar 8, 2024

The fix we currently have (a third token "optional" following the second, kind token "label") is not conformant with gohcl/doc.go:

// Within each tag there are two comma-separated tokens. The first is the
// name of the corresponding construct in configuration, while the second
// is a keyword giving the kind of construct expected.

We could also use another kind, like "optional_label", to get the same effect. So even if the extraction of name and kind (in https://github.com/hashicorp/hcl/blob/57f8bbf184a628a6dedb36520db1c90bfab7fb06/gohcl/schema.go#L144 and following) becomes stricter, it should better not fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant