Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watching of referenced files #697

Open
alex-schneider opened this issue Feb 1, 2023 · 3 comments · Fixed by #747
Open

Watching of referenced files #697

alex-schneider opened this issue Feb 1, 2023 · 3 comments · Fixed by #747
Milestone

Comments

@alex-schneider
Copy link
Contributor

We have to watch (-watch) for referenced files in the config, e.g. openapi/file, settings/ca_file etc.

@johakoch
Copy link
Collaborator

johakoch commented Feb 3, 2023

There are three types of file attributes:

mandatory

block attribute
openapi file
saml idp_metadata_file
spa bootstrap_file

optional without alternative

block attribute
api error_file
endpoint error_file
error_handler error_file
files error_file
server error_file
settings ca_file

optional with alternative

block attribute alternative
basic_auth htpasswd_file password
certificate ca_certificate_file ca_certificate
certificate leaf_certificate_file leaf_certificate
certificate private_key_file private_key
certificate public_key_file public_key
jwt key_file key
jwt permissions_map_file permissions_map
jwt roles_map_file roles_map
jwt signing_key_file signing_key
jwt_signing_profile key_file key
tls server_ca_certificate_file server_ca_certificate
tls client_certificate_file client_certificate
tls client_private_key_file client_private_key

I'd propose to first concentrate on watching already existing file attributes, that might have their values changed, before also trying to watch newly added (or removed) optional attributes.

@johakoch johakoch linked a pull request Feb 8, 2023 that will close this issue
@johakoch johakoch linked a pull request Mar 27, 2023 that will close this issue
@johakoch johakoch removed a link to a pull request Mar 27, 2023
@johakoch johakoch added this to the 1.13 milestone Mar 27, 2023
@johakoch
Copy link
Collaborator

I don't remember which attributes are already watched. Should we reopen this issue to implement watching to more attributes?

@malud
Copy link
Collaborator

malud commented Mar 28, 2024

It seems a generic implementation for all abs file refs but I am missing any test-case for this.

@malud malud reopened this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants