feat(atomic): add ipx facets #2565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pull Request Report PR Title ✅ Title follows the conventional commit spec. Bundle Size
|
dguerinCoveo
changed the title
dguerinCoveo
commented
Nov 24, 2022
packages/atomic/src/components/common/atomic-icon-button/atomic-icon-button.tsx
Outdated
Show resolved
Hide resolved
btaillon-coveo
approved these changes
Nov 24, 2022
ThibodeauJF
reviewed
Nov 24, 2022
packages/atomic/src/components/ipx/atomic-ipx-refine-toggle/atomic-ipx-refine-toggle.pcss
Outdated
Show resolved
Hide resolved
ThibodeauJF
reviewed
Nov 24, 2022
packages/atomic/src/components/ipx/atomic-ipx-refine-toggle/atomic-ipx-refine-toggle.tsx
Show resolved
Hide resolved
ThibodeauJF
reviewed
Nov 24, 2022
olamothe
approved these changes
Nov 24, 2022
packages/atomic/src/components/ipx/atomic-ipx-refine-modal/atomic-ipx-refine-modal.tsx
Show resolved
Hide resolved
pathiery
reviewed
Nov 24, 2022
mikegron
approved these changes
Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://coveord.atlassian.net/browse/SVCINT-1948 => Add IPX facets.
2 components added:
atomic-ipx-refine-toggleandatomic-ipx-refine-modal.They are essentially copies of
atomic-insight-refine-toggleandatomic-insight-refine-modal, but with the normal search page engine. Let me know if you think we should implement some inheritance to reduce the number of duplicate lines between the two.Screen.Recording.2022-11-24.at.7.35.44.AM.mov
Edit: Updated the svg size of the filter
Edit2: Updated width of the SVG filter