Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we move away from "TRUE"/"FALSE"? #215

Open
reptile18 opened this issue Jul 28, 2020 · 1 comment
Open

Can we move away from "TRUE"/"FALSE"? #215

reptile18 opened this issue Jul 28, 2020 · 1 comment
Labels
idea Something, possibly crazy, to consider infrastructure Getting stuff into and keeping it in production. DevOps.

Comments

@reptile18
Copy link
Collaborator

reptile18 commented Jul 28, 2020

I'd like us to move away from using "TRUE"/"FALSE" in our activity data and instead use true/false:
image

Using "TRUE"/"FALSE" requires an additional transform when getting and setting the value.

Using true/false is like this:

<v-switch
  label="Inside?"
  :input-value="activity.isInside"
  @change="saveValue('isInside', !activity.isInside)"
></v-switch>

Using "TRUE"/"FALSE" is like this:

<v-switch
  label="Show Location?"
  :input-value="activity.showLocation === 'TRUE'"
  @change="saveValue('showLocation', showLocationToggled)"
></v-switch>
showLocationToggled() {
  return this.activity.showLocation === "TRUE" ? "FALSE" : "TRUE";
}

┆Issue is synchronized with this Trello card by Unito

@reptile18 reptile18 added idea Something, possibly crazy, to consider infrastructure Getting stuff into and keeping it in production. DevOps. labels Jul 28, 2020
@awwaiid
Copy link
Member

awwaiid commented Jul 29, 2020

Yeah. Now that we have more experience import/exporting data I think this would be fine to change to actual true/false instead of strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idea Something, possibly crazy, to consider infrastructure Getting stuff into and keeping it in production. DevOps.
Projects
None yet
Development

No branches or pull requests

2 participants