Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the slug breaks the activity [Proposed Label: Bug] #229

Open
bluejayfang opened this issue Jul 31, 2020 · 6 comments
Open

Changing the slug breaks the activity [Proposed Label: Bug] #229

bluejayfang opened this issue Jul 31, 2020 · 6 comments
Labels
bug Something isn't working

Comments

@bluejayfang
Copy link

bluejayfang commented Jul 31, 2020

indoor-family-gathering and outdoor-family-gathering don't show up on the site and can't be called in the admin. But if you change the URL back to the old slug, the admin panel displays the results

┆Issue is synchronized with this Trello card by Unito

@bluejayfang
Copy link
Author

Managed to "fix" indoor family gathering by reverting to the old slug. This did not work for outdoor family gathering.

@bluejayfang bluejayfang changed the title Changing the slug breaks the activity Changing the slug breaks the activity [Proposed Label: Bug] Jul 31, 2020
@reptile18
Copy link
Collaborator

I think these are two separate issues:

  1. I definitely think we should lock down the slug to prevent anyone from breaking an activity accidentally.

  2. It looks like there are two activities in the database with the same slug, which might be why the activity is broken.
    image

(After briefly enabling the activity), I noticed that it's complaining about nodes in the data that are unpopulated:
image

Which definitely means it's choosing the unpopulated outdoor family gathering over the populated one.

Deleting the unpopulated one should fix the issue.

Also, once we get the curation pipeline down, this should no longer happen. One of the checks would be to make sure not to create a duplicate activity.

@bluejayfang
Copy link
Author

This is fascinating. Can we take a little time to stress test this a bit more next week? Agreed on the curation pipeline.

But where did the duplicate come from? And why would the empty activity not show up in the admin panel alongside the filled one?

This activity set (indoor/outdoor) for family gatherings is brand new for today.

@reptile18
Copy link
Collaborator

There's only so much I can answer. First, I think it IS showing up in the admin panel:
image
I think it's the blank one here.

Second, I don't know where it came from because when I was doing the timestamps, I stupidly didn't have the "create new activity" workflow or disable/delete workflows log any timestamps or users.

@reptile18
Copy link
Collaborator

reptile18 commented Jul 31, 2020

Was just about to break out an issue from this one about needing to make sure we don't create activities with duplicate slugs, but turns out we already do have validation:
image

No idea how the second going to an outdoor-family-gathering made it through...

@awwaiid
Copy link
Member

awwaiid commented Sep 17, 2020

Also if you have a completely incorrect activity url it will break. We can either display a message or re-direct to main search page.

@botanical botanical added the bug Something isn't working label Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants