Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Activity Bug #232

Open
reptile18 opened this issue Aug 1, 2020 · 0 comments
Open

Add Activity Bug #232

reptile18 opened this issue Aug 1, 2020 · 0 comments
Labels
admin bug Something isn't working
Milestone

Comments

@reptile18
Copy link
Collaborator

reptile18 commented Aug 1, 2020

No, this isn't that bug...

But it is interesting, nonetheless.

I was investigating the generation of activities that seemingly have no data other than disabled set to true. Trying different tests based on what the code does and I found that in the case where an activity's name and slug doesn't match (i.e. slugify returns a different value for the slugification of the name than the actual activity slug), something interesting happens.
image

If one tries to create an activity with a name that would generate an identical slug:
image

It passes the test for "Does an activity already exist that has the same name?," doesn't show an error in the popup, however, because the slug is identical to the existing activity, we instead are taken to the existing activity:
image

What's more, it sets fields on the activity as though it was a new activity.

image
Note: disabled is now true, and the name has changed...

┆Issue is synchronized with this Trello card by Unito

@reptile18 reptile18 added bug Something isn't working admin labels Aug 1, 2020
@awwaiid awwaiid added this to the SeptReps milestone Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants