Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Consider) Persist region in a cookie #282

Open
awwaiid opened this issue Oct 15, 2020 · 0 comments
Open

(Consider) Persist region in a cookie #282

awwaiid opened this issue Oct 15, 2020 · 0 comments

Comments

@awwaiid
Copy link
Member

awwaiid commented Oct 15, 2020

We were saving ALL state into localStorage which was confusing. But now we don't save ANY state, and if you navigate to the site it doesn't remember what region you most recently selected. See if we can save the region in a cookie!

Note:

  • Test out the /embed-demo.html path to make sure we don't break embedding
  • If the embedded demo locks you to a region that's fine for it to be come your new default region, but you should be able to change regions on the full site

┆Issue is synchronized with this Trello card by Unito

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant