Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to make QR larger in size? #75

Closed
gregory-villmann opened this issue Aug 5, 2021 · 19 comments
Closed

Possibility to make QR larger in size? #75

gregory-villmann opened this issue Aug 5, 2021 · 19 comments
Labels
enhancement New feature or request

Comments

@gregory-villmann
Copy link

Using iPhone 11, the QR seems to be rather small. The Estonian government has came up with a website https://kontroll.digilugu.ee/ to test the validity of the passes. The website can not scan my wallet code as it's too small on my phone... Is there a possibility to make the QR larger?

@laurazard
Copy link

As far as I know, the .pkpass/wallet pass format does not allow the size/style of anything to be customized, which is quite unfortunate but not something that can be addressed by anyone outside apple.

@marcelpietsch
Copy link

It seems that the problem lies in the complexity of the QR code, which makes it's individual pixels rather small. I don't think that the image container can be made bigger, as the wallet pass templates from Apple dictate that area's sizing.

Take a look at the examples over here: https://www.passcreator.com/de

@marvinsxtr
Copy link
Member

marvinsxtr commented Aug 5, 2021

A possible solution is to embed a link into the pass fields which contains the complete QR Code data and can be displayed bigger in a browser. Got the idea from https://coronapass.fabianpimminger.com

@marcelpietsch
Copy link

But where would the QR code image file be hosted in that case?

@marvinsxtr
Copy link
Member

marvinsxtr commented Aug 5, 2021

The file would not be hosted anywhere as that would be a huge privacy issue. As far as I understood, the payload is passed as an URL parameter and the site only displays it.

@marvinsxtr marvinsxtr added the enhancement New feature or request label Aug 5, 2021
@marcelpietsch
Copy link

That's what I was going for. Right, converting it to base64 makes sense. This could help.

https://github.com/renanbastos93/image-to-base64

@marvinsxtr
Copy link
Member

I think converting the actual payload to base64 is better. I bet there is some JavaScript library which can display a QR code from a payload.

@laurazard
Copy link

laurazard commented Aug 5, 2021

If I'm understanding that proposed approach correctly @marvinsxtr, this would only work for as long as the user has an active internet connection, therefore limiting its usability -- especially considering one might be required to show this at airports, different countries, etc. when traveling where one might not immediately have an internet connection. I wonder if it wouldn't be simpler to just have a link to open a webview with the base64 encoded image.

@marvinsxtr
Copy link
Member

marvinsxtr commented Aug 5, 2021

If Safari can natively show the image when it's passed as a url param, I would also support encoding the image instead of the payload. If not, the webview would also have to be hosted somewhere and require an internet connection.

@marvinsxtr
Copy link
Member

marvinsxtr commented Aug 5, 2021

Just noticed that opening a link in the pass only works when opening the actual wallet app and not when using the double press on the power button. Which makes sense because Safari is not available from lock screen. Kinda defeats the purpose of having the pass in the wallet for quick access.

@artem-from-ua
Copy link

artem-from-ua commented Aug 26, 2021

I've just filled a bug report in Apple Feedback app with the issue description. I mentioned about two issues: small QR-code image in the Wallet app (lots of free space around on the display) and unnecessary error correction set to "L" while "M" is completely OK for smartphone/watch displays.

It would be nice to show Apple more attention from the community to the problem. And now is a right time before iOS 15 release.

@dotsam
Copy link

dotsam commented Sep 21, 2021

Looks like Apple is bringing official support for this to iOS 15.1, the screenshot here shows a QR code that appears to be approximately twice as large https://www.macrumors.com/2021/09/21/ios-15-vaccine-card-wallet-app/

@Ein-Tim
Copy link
Contributor

Ein-Tim commented Sep 21, 2021

@dotsam

What the MacRumors article mentions is the extension of verifiable health records to also support COVID-19 vaccinations and test results with the option to also store certificates in the Wallet directly from the health app (where the verifiable health records are stored).

However, this does not improve the situation we have here, as currently the EU digital COVID certificate system is in use all across Europe, but verifiable health records are only available for organizations that issue SMART Health Cards.
This is another standard and has nothing to do with the system in use here.

However, maybe Apple adds a new QR-Code size for this kind of card, not only for "their" COVID-19 vaccination and test certificates which are stored through the health app but for all developers.
If this is the case it would probably be an easy task to adjust the QR code size to the bigger one.

I hope I didn't mix up anything here 😅

@janbrasna
Copy link

I'm not sure if Safari is the handler app for data: protocol, or if such link would be recognized and enabled as a link in the first place. (Otherwise yes, Safari gladly opens inline data: base64 content/images without issues.)

Let's just hope the 15.1 coming out of beta any given day 🤞 brings us bigger QR code layout options.

@mcdado
Copy link

mcdado commented Oct 26, 2021

Looks like Apple is bringing official support for this to iOS 15.1, the screenshot here shows a QR code that appears to be approximately twice as large https://www.macrumors.com/2021/09/21/ios-15-vaccine-card-wallet-app/

Looks like this new system does not work with EU Green Pass, but only the Californian system? Such a pity.

@massijay
Copy link

massijay commented Oct 26, 2021

Now that iOS 15.1 is out maybe it's possible to use the new pass format with bigger QR code, I haven't found anything about this on the docs yet however

@Ein-Tim
Copy link
Contributor

Ein-Tim commented Oct 26, 2021

@mcdado

Looks like this new system does not work with EU Green Pass, but only the Californian system? Such a pity.

Yeah, like I wrote above: #75 (comment)

@marvinsxtr
Copy link
Member

The larger QR code can now be viewed by tapping on the link on the back of the pass (when opening the actual Wallet app and with internet connection). See #142 Unfortunately, Safari does not open data: URLs from the Wallet app.

@marvinsxtr
Copy link
Member

marvinsxtr commented Dec 27, 2021

As there does not seem to be a better solution to this problem atm, I will close this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

10 participants