Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout in the transport should be reset #1720

Open
sereysethy opened this issue May 18, 2022 · 1 comment
Open

Timeout in the transport should be reset #1720

sereysethy opened this issue May 18, 2022 · 1 comment

Comments

@sereysethy
Copy link
Contributor

Describe the bug
In the ssh transport, there is a timeout and it is only reset when the connection is lost. In the code, it says that the timeout is reset once the authentication succeeds. But I think this is not the case.

In the current state, when a user is connected and opens an interactive shell. Even there is data flow between the client and the server, the connection is timeout.

The timeout in the protocol.py is never reached unless it is less than that set in the transport.

To Reproduce
Steps to reproduce the behavior:

  1. Login as a user and open a shell
  2. Type something until the timeout is reached.

Expected behavior
My suggestion is to reset the timeout of the transport in the protocol right after the connectionMade() in HoneyPotBaseProtocol.

If you agree to the idea, I will make a change.

@lcashdol
Copy link

lcashdol commented Sep 6, 2022

I agree. This bug also causes file transfers over ssh to be truncated if they are large regardless of the file transfer still occurring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants