Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code dispersion when creating aggregation.automaticTitle #296

Open
JF-Cozy opened this issue Oct 11, 2023 · 0 comments
Open

Code dispersion when creating aggregation.automaticTitle #296

JF-Cozy opened this issue Oct 11, 2023 · 0 comments
Labels
✨ enhancement New feature or request

Comments

@JF-Cozy
Copy link
Contributor

JF-Cozy commented Oct 11, 2023

For automatic generation of trip titles (stored in aggregation.automaticTitle), see PR #295 we had to use a method in several different places:

  • when modifying a contact on a trip
  • during the aggregation service
  • during the recurrence service
  • when modifying a mode of transport on a trip

It would have been preferable to share a function for saving a timeseries, to use this function in all these cases, and to make the modification only in this function.
@JF-Cozy JF-Cozy added the ✨ enhancement New feature or request label Oct 11, 2023
@JF-Cozy JF-Cozy mentioned this issue Oct 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
✨ enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JF-Cozy