Comparing changes
Open a pull request
Commits on Oct 3, 2022
-
fix: Expose sendNotification from cozy-client realtime plugin
It is especially needed in harvest to send notification from harvest to the banks application to know when a job is waited for. And since the realtime plugin is supposed to expose the same api as CozyRealtime
Commits on Oct 4, 2022
-
-
fix: Wording of driver_license suggestion
And add stranger driver license to suggestion list
-
-
feat: Allow to pass custom Properties to OAuthForm wrapper
via OAuthFormWrapperCompProps and without unmounting/remounting OauthForm on each rerender This avoids the disparition of the BI webview in banks when a new job is expected
Commits on Oct 11, 2022
-
fix: This.input is not defined
Since a few versions, Cozy-UI's input has been converted to function with a forwardRef. It results that the ref callback can be called after the didMount() method so calling focus() on it crash the app. Since cozy-auth is only on "maintenance" mode, I just remove this focus stuff since almost all webviews will focus on the input if there is only one displayed.
-
fix: Add explicit blocked popup message
When an OAuth popup was blocked, we got "null is not an object" error in console. Now we will get "Popup was blocked by browser. Be sure to not call showPopup asynchronously" which may be more explicit
Commits on Oct 12, 2022
-
fix(mespapiers): Redirections to homepage
When upgrading the router, we changed the redirects on the homepage from `/paper` to `/`, for no special reason. But as a result, it was the redirection route on the application side that was triggered, and that caused a dismount/remount of the lib.
-
fix(mespapiers): Default route for the lib
BREAKING CHANGE: Since the router update, applications were no longer forced to use the `/paper` route to consume lib. This change was not intended. With this fix we get back the old expected behavior. Unlike adding the `/*` like this `/paper/*` required with the new router. ``` <Route path="/paper/*" element={<PaperView />} /> ``` -
Commits on Oct 19, 2022
Commits on Oct 24, 2022
-
refactor: Turn OAuthForm into a functional component
Use the same component life cycle as its wrapper component when composing with `withConnectionFlow()` and allow usage of hooks such as `useFlowState()`.
-
refactor: Move trigger error card into KonnectorAccountTabs
No need to duplicate the error management logic in both tabs.
-
refactor: Extract fetchExtraOAuthParams effect
`OAuthForm` requires to fetch extra OAuth parameters to display the `OAuthWindow` and this was done in a `useEffect` call. However, we want to be able to display this window from other components so, instead of duplicating the fetch logic, we create a new `useOAuthExtraParams` hook that will be called in every component that needs it. This means that the part of the `OAuthForm`'s `useEffect` call that was triggering the OAuthWindow display will now be dependent on the existence of the required extra parameters.
-
refactor: ConnectionFlow requires a konnector
In some places we can see that we expect an instantiated `ConnectionFlow` to have a `konnector` attribute which comes in most cases from a constructor argument. Since we'll be relying even more on the presence of that `konnector`, we make sure that all tests instantiating a `ConnectionFlow` do pass a `konnector` argument.
-
feat: Reconnection with BI webviews & webhooks
When a banking connector fails with a LOGIN_ERROR status, we offer users to reconnect their connector via the BI webview. Once the user closes the webview, we trigger a connector launch to try the new credentials (we can still encounter an error) and fetch the new data. The user sees a synchronization is in progress within the connector's modal in Harvest. However, we want to use BI webhooks to receive data pushed from BI rather than pulling data when we trigger the connector and the current process cannot handle this because: - we won't trigger the connector ourselves (it will be triggered by a webhook call) so the user wouldn't see a synchronization is in progress - the user might not close the webview or the webhook call could be received before the webview is closed so we need to expect it ahead of time Since we don't have much control over the webview, we'll update the in-memory connection flow state to expect the connector trigger launch (via the BI webhook call). The update will be done once the user opens the webview by clicking the "Reconnect" button displayed in the connector error card. From the user perspective, this trigger launch expectation will be seen as a synchronization in progress. Once the connector trigger is launched, we'll remove this in-memory state and start watching for changes on the connector job. -
feat: Send realtime notifications when expecting a trigger
This will allow the banks application to display an import in progress when needed
-
fix: Add useEffect dependencies to useOAuthExtraParams hook
To avoid to a request to token cache on every render
-
-
fix: Do not depend only on konnector.slug for useEffect dependencies
Used React.memo and use-deep-compare-effect for hooks to not have infinite rerenders. But the real cause for these rerenders comes from the home application which generates a new konnector object on each rerender.
-
-
-
Commits on Oct 27, 2022
Commits on Oct 28, 2022
-
-
refactor: Allow to set cozy-realtime used by OAuth components
This will allow unit tests to trigger realtime events which will be detected by OAuthWindow and BIContractActivationWindow
-
-
refactor: Object parameter for prepareOAuth
Better to have named parameters with this number of parameters, plus this gets more consistent with getOAuthUrl.
-
refactor: Extract extractOAuthDataFromUrl in OAuthWindow
To have better ts type and less repetition of the same code
There are no files selected for viewing