Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add completion for fish shell #2337

Closed
mamyn0va opened this issue Jan 21, 2020 · 4 comments
Closed

Add completion for fish shell #2337

mamyn0va opened this issue Jan 21, 2020 · 4 comments

Comments

@mamyn0va
Copy link
Contributor

Currently, only bash and zsh completions are supported by cozy-stack CLI. As fish shell is getting more and more popular among user-friendly shells, I think it deserves its own completion.

@nono
Copy link
Member

nono commented Jan 22, 2020

We are using a library called cobra for managing the CLI options parsing. There is a PR opened for adding fish completion, but it has not been merged yet: spf13/cobra#754

@mamyn0va
Copy link
Contributor Author

Is this independent from cozy-stack ? I mean, as soon as cobra will merge this PR, will the fish completion be working in cozy-stack, or will you have to create a completion file, as for bash and zsh ?

@nono
Copy link
Member

nono commented Jan 22, 2020

When the PR will be merged, we will update https://github.com/cozy/cozy-stack/blob/master/cmd/completion.go, and use it to generate the completion file for fish.

@mamyn0va
Copy link
Contributor Author

mamyn0va commented Jan 22, 2020

Ok, great.

@mamyn0va mamyn0va reopened this Jan 22, 2020
@nono nono closed this as completed in 98546d5 Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants