New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IntentHandler #206

Open

y-lohse opened this issue May 24, 2018 · 3 comments

y-lohse commented May 24, 2018

Hi, I used your IntentHandler code in cozy/cozy-contacts#155 and it worked very well! The new intent handling structure is great!

I just made a few changes to the file but linters fucked up the diff..

I had to wrap the spinner in a thing that would center it. The IntentModalin Ui already has a spinner, maybe we could look at how it's done there to avoid the extra element
I used the new Empty component from UI for the error view.
And I added proptypes because I had too.

I can contribute these changes back to cozy-store but I'm not sure they are too interesting, but if/when we integrate these components in a separate lib, we should keep these things in mind :)

The text was updated successfully, but these errors were encountered:

Contributor

gregorylegarec commented May 24, 2018

Thanks @y-lohse for your feedback, we'll try to set up the lib cozy-interapp as soon as possible and pick your improvement. 👌

Contributor

CPatchane commented May 24, 2018

Thanks a lot for this feedback @y-lohse :D
Indeed it was the idea to externalize this component for others in the intents library.

Member

nono commented Mar 4, 2019

Have we integrated those changes to https://github.com/cozy/cozy-libs/tree/master/packages/cozy-interapp?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment