Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Useless dependencies #12

Open
israelKusayev opened this issue Oct 29, 2020 · 2 comments
Open

Question: Useless dependencies #12

israelKusayev opened this issue Oct 29, 2020 · 2 comments

Comments

@israelKusayev
Copy link

Why do you need all these dependencies
image
For example I don't see any use of workbox-google-analytics in this template

@dfyz011
Copy link

dfyz011 commented May 5, 2022

Hi! Yesterday I tried this template for the first time and I have the same question. Why there is still no answer?

@jeffposnick
Copy link
Collaborator

Back when I was first involved in the c-r-a project, there was no flexibility to install additional packages beyond what was provided by the official configuration. I believe that this restriction still applies, or at least it's not very straightforward to add in packages beyond what's in the template's configuration.

The thinking here was that if somewhere were to read through the https://developer.chrome.com/docs/workbox/ documentation and realize that they needed to modify their service worker to use a module like workbox-google-analytics, they would be unable to add it in after the fact—and there wouldn't be a clear way to explain in the Workbox docs which modules are included with c-r-a and which aren't.

Maybe things have changed in the c-r-a ecosystem since the earlier days, and it's now easier to add in additional packages after setting things up from a template? I'm not very active in the c-r-a ecosystem right now, so I am not sure. If someone can confirm that c-r-a is now flexible enough to do that, we can drop all of the packages that aren't used directly by the default service worker's code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants