Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading Workbox to v6 and above #18

Open
Transfusion opened this issue Feb 6, 2021 · 4 comments
Open

Upgrading Workbox to v6 and above #18

Transfusion opened this issue Feb 6, 2021 · 4 comments

Comments

@Transfusion
Copy link

Use Case: I want to define a custom import { Strategy } from "workbox-strategies"; (that fetches data from IndexedDB, so I can use the registerRoute syntax of Workbox).

https://developers.google.com/web/tools/workbox/modules/workbox-strategies#custom_strategies

GoogleChrome/workbox#2455

Strategy.ts was only introduced in v6.

Will there be any adverse effects if I simply npm i workbox-strategies@6.1.0, along with all the other related packages?
I'll update this issue after I try shortly.

@ZYinMD
Copy link

ZYinMD commented Apr 3, 2021

@Transfusion Did you find any adverse effects?

@ZYinMD
Copy link

ZYinMD commented Apr 18, 2021

You could check the "breaking changes" section in the v6 release note for details.

I did the upgrade, and found no adverse effect.

@sm2017
Copy link

sm2017 commented Nov 9, 2021

@ZYinMD You mean, No need to change the code to update?
@jeffposnick can you please take a look?

@piotr-cz
Copy link

@ZYinMD
How did you upgrade? The react-scripts@^4.0.0 dependes on workbox-webpack-plugin@5.1.4 which depends on workbox-build@5.1.4

npm ls workbox-build

`-- react-scripts@4.0.3
  `-- workbox-webpack-plugin@5.1.4
    `-- workbox-build@5.1.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants