Skip to content
This repository has been archived by the owner on Jan 23, 2021. It is now read-only.

Move to Docker organization #234

Closed
crazy-max opened this issue Aug 27, 2020 · 5 comments
Closed

Move to Docker organization #234

crazy-max opened this issue Aug 27, 2020 · 5 comments

Comments

@crazy-max
Copy link
Owner

crazy-max commented Aug 27, 2020

I plan to archive this repository following the work I did with the Docker team on an action that will be formalized in their organization: https://github.com/docker/setup-buildx-action

There will be a total of 4 actions:

I have also created another repo to check the behavior of these actions: ci.yml / full.yml.

A real example is available on this repo.

You can already try them out and report any issues you may encounter.

@ttshivers
Copy link

In your examples, I notice you don't use any caching actions for the docker builds.

@crazy-max
Copy link
Owner Author

@ttshivers See https://github.com/docker/build-push-action/tree/v2#leverage-github-cache as an example

@scyto
Copy link

scyto commented Sep 21, 2020

I only just found this solution, been looking for something like this for 2+ years. It's awesome. I implemented crazy-max's native solution first. Then found this bug so rebuilt in new docker owned variant. Their documentation is more confusing; but got it all sorted.

If anyone is interested, this is what a complete non-programmer, who had never seen this before, managed in ~6 hours - most of that was troubleshooting the weird rpc bug on push (tl;dr its random and i can't, as you all know!). This example uses the new docker workflows/actions and one of the dockerhub readme / description actions/workflows.

https://github.com/scyto/infinitude/tree/master/.github/workflows

@crazy-max sent you a thanks.
Alex

PS i had never used actions and workflows before today either...

@scyto
Copy link

scyto commented Sep 21, 2020

In your examples, I notice you don't use any caching actions for the docker builds.

I just implemented the cache, not sure what it really buys me as even with zero dockerfile changes it rebuilds all architecture tags from the ground up every run? It didn't reduce the time when the cache was used....

@crazy-max
Copy link
Owner Author

v1.0.0 of docker/setup-buildx-action is now available and published to the marketplace. This action will be archived and user prompted to use the official Docker action.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants