Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Babel is causing issues with the PointsRenderer example #94

Closed
rohan-deshpande opened this issue May 30, 2020 · 1 comment
Closed

Babel is causing issues with the PointsRenderer example #94

rohan-deshpande opened this issue May 30, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@rohan-deshpande
Copy link
Collaborator

rohan-deshpande commented May 30, 2020

Very weird and hard to solve issue, it seems the latest version of babel is causing issues with the points renderer example where performance slows to a crawl while rendering. The issue arose in 28c9357 where babel was upgraded to 7.8.4 from 7.5.0.

Currently, commenting out the following lines from the webpack config (ie., removing babel entirely) seems to resolve the issue

      {
        test: /(\.jsx|\.js)$/,
        loader: 'babel-loader',
        exclude: /(node_modules)/,
      },

Doing this and then running

npm run build
cd website 
rm -rf node_modules/three-nebula
npm run link-src
npm run dev

And navigating to http://localhost:3000/examples/point-zone will show that the example is working as normal. If you run it with babel-loader the example grinds to a halt.

I've tried upgrading all babel dependencies to see if the issue has been subsequently fixed, but it seems it is still a problem.

Obviously I'd love to be able to solve this from the library's source code itself, but it's really hard right now to know exactly what is causing it. This could be related to babel/babel#11356

Right now there's a few options

  • Downgrade babel back to when it worked
  • Try to find whatever is causing this issue in the source code and fix it
  • Try to figure out what transformer in preset-env is causing the issue
  • If the linked babel issue is the problem, then dropping IE11 support would mean that the lib wouldn't need to transform ES6 classes into functions and dropping support would mean that this transformer could be excluded
@rohan-deshpande rohan-deshpande added the bug Something isn't working label May 30, 2020
@rohan-deshpande
Copy link
Collaborator Author

Resolved by #95

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant