Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maxRetries and non-existing screenshots #182

Open
Perni1984 opened this issue Sep 14, 2021 · 1 comment
Open

maxRetries and non-existing screenshots #182

Perni1984 opened this issue Sep 14, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@Perni1984
Copy link

We are using creevey in our ci pipeline runs together with a maxRetries: 6 setting.

Whenever we are creating a new story and thus the reference screenshot is not existing yet, we are getting back a Expected image does not exists message, which is fine. Together with a maxRetries: 6 setting however, it is retried up to 6 times to find the reference screenshot. I think those screenshots that are not found should not be retried, despite a maxRetries setting in creevey.config.js.

@wKich
Copy link
Collaborator

wKich commented Sep 17, 2021

@Perni1984 Yeah, that sounds reasonable. I'll try to take it somewhere in October. Sorry for the delay, I have issues with moving to a new flat and I'm preparing to speak at FrontendConf https://frontendconf.ru/moscow/2021/abstracts/7436

@wKich wKich added the bug Something isn't working label Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants