Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the overhead of opacity annotations #995

Open
xldenis opened this issue Apr 29, 2024 · 2 comments
Open

Reduce the overhead of opacity annotations #995

xldenis opened this issue Apr 29, 2024 · 2 comments

Comments

@xldenis
Copy link
Collaborator

xldenis commented Apr 29, 2024

Currently, assume that a function with no #[open] annotation has opacity #[open(self)], despite this, there are over a 190 specific usages of #[open(self)]. These should be investigated and a mechanism should be developed to make them unnecessary.

It seems like most of these occurrences have to do with traits so perhaps there is something to fix in that regard?

@jhjourdan
Copy link
Collaborator

What I remember is that we decided that any non-private logic definition should have an explicit transparency. That's the reason why these open(self) are necessary. If we get rid of these tests, then we shoudl get the desired behavior.

@xldenis
Copy link
Collaborator Author

xldenis commented Apr 29, 2024

What I remember is that we decided that any non-private logic definition should have an explicit transparency. That's the reason why these open(self) are necessary. If we get rid of these tests, then we shoudl get the desired behavior.

Yes, I think we should do that immediately and start with open(self) as a default transparency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants