Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Doesn't fail on infer parser failed #107

Open
burner1024 opened this issue Jan 17, 2023 · 4 comments
Open

[BUG] Doesn't fail on infer parser failed #107

burner1024 opened this issue Jan 17, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@burner1024
Copy link

What exactly happened?
Steps to reproduce the behavior:

Setup incorrect config, I guess.

What should've happened?
Action should've failed.

How did it look?
Captura desde 2023-01-17 09-31-01

Where did you encounter the problem?

  • Run
  • Version 4.2
@burner1024 burner1024 added the bug Something isn't working label Jan 17, 2023
@creyD
Copy link
Owner

creyD commented Jan 23, 2023

That's a weird one.. I found a solution for the problem, but not why it doesn't fail on this. This is the call I make prettier $INPUT_PRETTIER_OPTIONS \ || { PRETTIER_RESULT=$?; echo "Problem running prettier with $INPUT_PRETTIER_OPTIONS"; exit 1; } which fails if prettier fails with error code. But maybe it doesn't fail with an error code?

@creyD
Copy link
Owner

creyD commented Jan 23, 2023

Update: This is due to the dry-run. Dry-run feature only shows but doesn't actually fail the action. As per documentation it should also fail the action.

@creyD
Copy link
Owner

creyD commented Jan 23, 2023

@fsz-codeshop What do you say, is this works as intended or should this be changed?

@creyD
Copy link
Owner

creyD commented Jan 10, 2024

Hope you all had a great start into the year. @fsz-codeshop Could you please take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants