Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDEA: Add push_options parameter #120

Open
chicco785 opened this issue Jun 28, 2023 · 3 comments · Fixed by #121 or zaphiro-technologies/prettier_action#1
Open

IDEA: Add push_options parameter #120

chicco785 opened this issue Jun 28, 2023 · 3 comments · Fixed by #121 or zaphiro-technologies/prettier_action#1
Labels
enhancement New feature or request

Comments

@chicco785
Copy link

chicco785 commented Jun 28, 2023

push_options are not set as environmental variables, due to that, they cannot be passed to the shell script

env:
INPUT_COMMIT_MESSAGE: ${{ inputs.commit_message }}
INPUT_COMMIT_DESCRIPTION: ${{ inputs.commit_description }}
INPUT_SAME_COMMIT: ${{ inputs.same_commit }}
INPUT_COMMIT_OPTIONS: ${{ inputs.commit_options }}
INPUT_FILE_PATTERN: ${{ inputs.file_pattern }}
INPUT_PRETTIER_OPTIONS: ${{ inputs.prettier_options }}
INPUT_DRY: ${{ inputs.dry }}
INPUT_PRETTIER_VERSION: ${{ inputs.prettier_version }}
INPUT_ONLY_CHANGED: ${{ inputs.only_changed }}
INPUT_PRETTIER_PLUGINS: ${{ inputs.prettier_plugins }}
INPUT_WORKING_DIRECTORY: ${{ inputs.working_directory }}
INPUT_GITHUB_TOKEN: ${{ inputs.github_token }}
INPUT_CLEAN_NODE_FOLDER: ${{ inputs.clean_node_folder }}

@chicco785 chicco785 changed the title missing push_options [bug] missing push_options Jun 28, 2023
@creyD creyD changed the title [bug] missing push_options IDEA: Add push_options parameter Jun 30, 2023
@creyD creyD added the enhancement New feature or request label Jun 30, 2023
@koppor
Copy link

koppor commented Nov 17, 2023

Maybe, the feature #80 is a work-around for that. Having proper git pushes is a hard task - and maybe, another action should be used (and this action can focus on nice running of prettier)

@chicco785
Copy link
Author

@koppor in dev I think this is now tackled :)

@chicco785
Copy link
Author

see: #123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants