Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Should work when package-lock.json is not versioned #128

Open
koppor opened this issue Nov 17, 2023 · 3 comments
Open

[BUG] Should work when package-lock.json is not versioned #128

koppor opened this issue Nov 17, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@koppor
Copy link

koppor commented Nov 17, 2023

What exactly happened?

  1. Have a repository without package-lock.json
  2. Run action

What should've happened?

Everything working.

How did it look?

Deleting node_modules/ folder...
error: pathspec 'package-lock.json' did not match any file(s) known to git

Where did you encounter the problem?

Workarounds:

  • clean_node_folder: false does not work.
  • Version pacakge-json.lock in the repository
@koppor koppor added the bug Something isn't working label Nov 17, 2023
koppor added a commit to koppor/jabref that referenced this issue Nov 17, 2023
creyD added a commit that referenced this issue Jan 10, 2024
@creyD
Copy link
Owner

creyD commented Jan 10, 2024

Could you please check if it works if you use @dev instead of the version you are using? If yes, I will merge it.

@dmitvitalii
Copy link

Same problem here.

@creyD , tried the @dev version:

Installing prettier...
Checking plugin: prettier-plugin-organize-imports
Prettifying files...
Files:
/home/runner/work/_actions/creyD/prettier_action/dev/entrypoint.sh: line 64: prettier: command not found
Error: Process completed with exit code 1.

@bastien-snk
Copy link

I have the same problem here. I tried with the dev version also and got the same problem as @dmitvitalii.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants