Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Case 7.9.3 #79

Open
kelunik opened this issue Dec 19, 2017 · 2 comments
Open

Remove Case 7.9.3 #79

kelunik opened this issue Dec 19, 2017 · 2 comments

Comments

@kelunik
Copy link

kelunik commented Dec 19, 2017

Case Description

Send close with invalid close code 1004

Case Expectation

Clean close with protocol error code or drop TCP

According to https://tools.ietf.org/html/rfc6455#section-7.4.1 this code is reserved, but unlike 1005 or 1006, there's no language that forbids using the code, it therefore doesn't make sense to me to expect a 1002 or empty close reason. We currently send 1000 instead, which makes the test fail.

@nhooyr
Copy link

nhooyr commented May 31, 2019

Agreed, if in the future it has a real meaning, then all existing clients will throw needless errors when encountering it. It makes more sense for them to just echo it as normal and then let application code deal with its meaning.

@nhooyr
Copy link

nhooyr commented May 31, 2019

Actually, if its reserved, it could become a code that isn't allowed on the wire, it's pretty much undefined so it does make sense to preclude it from going on the wire.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants