Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Windows resize event match terminal::size #714

Merged
merged 2 commits into from Oct 9, 2022
Merged

Make Windows resize event match terminal::size #714

merged 2 commits into from Oct 9, 2022

Conversation

generic-user1
Copy link
Contributor

Previously, results from a Resize event were 1 less than results from terminal::size in both x and y dimensions.

This PR fixes #713

Was previously 1 less than expected in both x and y dimensions
Copy link
Member

@TimonPost TimonPost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh noes, good catch!

@TimonPost
Copy link
Member

Can you run cargo fmt?

@generic-user1
Copy link
Contributor Author

Yes! Added a commit after running cargo fmt

@TimonPost TimonPost merged commit f845cea into crossterm-rs:master Oct 9, 2022
@generic-user1 generic-user1 deleted the fix-windows-resize-event branch October 9, 2022 18:09
@eminence
Copy link

Any guess on when this fix might be released on crates.io?

eminence pushed a commit to eminence/crossterm that referenced this pull request Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resize events yield different results than terminal::size on Windows
3 participants