Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac doesnt report Shift or Ctrl with enter key #861

Open
pm100 opened this issue Feb 13, 2024 · 3 comments
Open

Mac doesnt report Shift or Ctrl with enter key #861

pm100 opened this issue Feb 13, 2024 · 3 comments

Comments

@pm100
Copy link

pm100 commented Feb 13, 2024

run the event-read example on plain mac terminal (ventura 13.3.1 M1 cpu)

Press shift, hit enter, no key modifier is reported.. Same for control.

If I use iterm2 it works due to the PushKeyboardEnhancementFlags call (If I comment that call out the behavior is the same as for vanilla terminal), but reading the description of that feature it should have no impact.

@joshka
Copy link
Contributor

joshka commented Feb 15, 2024

I suspect that Terminal.app probably doesn't have a way to report those keys at all. There's some good background about the various modes of terminal keyboard reporting on the kitty site, in particular this section https://sw.kovidgoyal.net/kitty/keyboard-protocol/#legacy-key-event-encoding suggests that to report Ctrl/Shift+Enter is something that needs the progressive enhancement.

@timstr
Copy link

timstr commented Feb 18, 2024

I'm also not seeing Shift or Control modifiers during an Enter key event using Linux. The Alt key works fine though. Pushing DISAMBIGUATE_ESCAPE_CODES and REPORT_ALL_KEYS_AS_ESCAPE_CODES doesn't seem to help. I'm running GNOME terminal 3.44.0 on Ubuntu 22.04

@timstr
Copy link

timstr commented Feb 20, 2024

Also missing ctrl+backspace on Linux. Switched to Kitty instead of GNOME Terminal and all three combinations (shift+enter, ctrl+enter, ctrl+backspace) are working. Also ligatures FTW

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants