Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another registry key #622

Open
AlekseyPopovv opened this issue Oct 30, 2023 · 9 comments
Open

Another registry key #622

AlekseyPopovv opened this issue Oct 30, 2023 · 9 comments
Labels
bug Something isn't working

Comments

@AlekseyPopovv
Copy link

Valid registry key:
HKEY_CURRENT_USER\Software\crow-translate\crow-translate

Missing registry key:
HKEY_CURRENT_USER\Software\Crow Translate\Crow Translate

@AlekseyPopovv AlekseyPopovv added the bug Something isn't working label Oct 30, 2023
@Shatur
Copy link
Member

Shatur commented Oct 30, 2023

In the latest release we switched to HKEY_CURRENT_USER\Software\crow-translate\crow-translate. You can remove the old one.

@Shatur Shatur closed this as completed Oct 30, 2023
@AlekseyPopovv
Copy link
Author

In version 2.11.0 the path in the registry is still HKEY_CURRENT_USER\Software\crow-translate\crow-translate

@Shatur
Copy link
Member

Shatur commented Oct 30, 2023

Yes, and it will be like this from now on.

@AlekseyPopovv
Copy link
Author

The installer does not remove this HKEY_CURRENT_USER\Software\crow-translate\crow-translate. Only removes this HKEY_CURRENT_USER\Software\Crow Translate\Crow Translate.
It needs to be fixed in the NSIS.

@AlekseyPopovv
Copy link
Author

If the program is running, the uninstaller does not remove all files.

@Shatur
Copy link
Member

Shatur commented Oct 30, 2023

We generate NSIS automatically. I think if you run the uninstaller from the previous version, it will remove HKEY_CURRENT_USER\Software\Crow Translate\Crow Translate. And after installing new version and running uninstaller it will remove HKEY_CURRENT_USER\Software\crow-translate\crow-translate. Correct?

@AlekseyPopovv
Copy link
Author

No. The new version of the installer still contains HKEY_CURRENT_USER\Software\Crow Translate\Crow Translate

@Shatur
Copy link
Member

Shatur commented Oct 30, 2023

Oh, I see. Probably it's because of this variable:

set(CPACK_PACKAGE_VENDOR ${APPLICATION_NAME})

Could you try changing it to ${PROJECT_NAME} locally and see if it fixes the issue? I don't have Windows machine right now.

@Shatur Shatur reopened this Oct 30, 2023
@Shatur
Copy link
Member

Shatur commented Oct 30, 2023

I don't understand this. What to do after the change?

Compile and run the installer. See instructions here.

Do you speak Russian?

I do, but I prefer to speak English on English-speaking platforms.

Can you add an option to save the settings file in another location?

This could be added, feel free to open a new issue about it.

@Shatur Shatur reopened this Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants