Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect pull request query params #164

Open
CzBiX opened this issue Feb 10, 2023 · 6 comments
Open

Incorrect pull request query params #164

CzBiX opened this issue Feb 10, 2023 · 6 comments
Labels
bug Something isn't working hacktoberfest This issue welcomes contributions for Hacktoberfest help wanted Extra attention is needed

Comments

@CzBiX
Copy link

CzBiX commented Feb 10, 2023

Describe the bug
https://github.dev/crowdin/github-action/blob/bcc23e98ecf8b2605a9265fdc63c60228ad814e5/entrypoint.sh#L98

the head param in here will not works, the API will just return all PRs.
it should something like org_name:branch_name.
see docs: here

To Reproduce
call GitHub API with head as simple branch name without org_name.

@CzBiX CzBiX added the bug Something isn't working label Feb 10, 2023
@andrii-bodnar andrii-bodnar added the help wanted Extra attention is needed label Feb 10, 2023
@andrii-bodnar
Copy link
Member

andrii-bodnar commented Apr 4, 2023

@CzBiX We have not been able to reproduce the issue in the context of the current action. Could you please share a full WF Step configuration and steps to reproduce the issue?

@andrii-bodnar andrii-bodnar closed this as not planned Won't fix, can't repro, duplicate, stale Apr 25, 2023
@CzBiX
Copy link
Author

CzBiX commented Apr 25, 2023

example API request:
image

The current code seems to work because the API ignores the head parameter and returns the last 30 PRs, which happen to have the PR corresponding to localization_branch_name.

It doesn't work when there are more than 30 PRs after localization branch in the project.

@andrii-bodnar
Copy link
Member

@CzBiX thanks for clarifying!

@andrii-bodnar andrii-bodnar reopened this Apr 25, 2023
@rhys-saunders
Copy link

We've also been experiencing this issue recently. Is there a known fix for this?

@andrii-bodnar andrii-bodnar added the hacktoberfest This issue welcomes contributions for Hacktoberfest label Sep 13, 2023
@aysensolko
Copy link

Hello! @andrii-bodnar can you please answer when it will fixed?

@andrii-bodnar
Copy link
Member

I'm thinking about switching to GH CLI instead of raw API calls - #220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest This issue welcomes contributions for Hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants