fix: infinite recursion on circular dependency (#720)

* fix: infinite recursion on circular dependency * Create moody-ligers-exercise.md --------- Co-authored-by: Jack Steam <jacksteamdev@gmail.com>
crxjs · Jun 18, 2023 · 557721e · 557721e
1 parent 322b9d1
commit 557721e
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/.changeset/moody-ligers-exercise.md b/.changeset/moody-ligers-exercise.md
@@ -0,0 +1,5 @@
+---
+"@crxjs/vite-plugin": patch
+---
+
+fix: infinite recursion on circular dependency
diff --git a/packages/vite-plugin/src/node/compileFileResources.ts b/packages/vite-plugin/src/node/compileFileResources.ts
@@ -26,14 +26,20 @@ export function compileFileResources(
     css: new Set(),
     imports: new Set(),
   },
+  processedFiles = new Set(),
 ): FileResources {
+  if (processedFiles.has(fileName)) {
+    return resources
+  }
+  processedFiles.add(fileName)
+
   const chunk = chunks.get(fileName)
   if (chunk) {
     const { modules, facadeModuleId, imports, dynamicImports } = chunk
     for (const x of imports) resources.imports.add(x)
     for (const x of dynamicImports) resources.imports.add(x)
     for (const x of [...imports, ...dynamicImports])
-      compileFileResources(x, { chunks, files, config }, resources)
+      compileFileResources(x, { chunks, files, config }, resources, processedFiles)
     for (const m of Object.keys(modules))
       if (m !== facadeModuleId) {
         const key = prefix('/', relative(config.root, m.split('?')[0]))
@@ -47,6 +53,7 @@ export function compileFileResources(
               script.fileName,
               { chunks, files, config },
               resources,
+              processedFiles,
             )
           }
       }