Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Update] Implement an auto-updater mechanism for newer releases #548

Closed
4 of 9 tasks
crypto-eddy opened this issue Jul 5, 2021 · 6 comments
Closed
4 of 9 tasks

Comments

@crypto-eddy
Copy link
Contributor

crypto-eddy commented Jul 5, 2021

Tasks

@crypto-eddy crypto-eddy self-assigned this Jul 5, 2021
@RainbowMiner
Copy link

Yes, please!

@crypto-eddy
Copy link
Contributor Author

Issue 1

There was one blocking issue with the stable version of electron updater electron-userland/electron-builder#5940.

It seems to be detecting new versions well but when it has to replace the binary, the checksum match fails.

Screen Shot 2021-07-06 at 12 48 14 AM

00:48:24.566 › Error: Error: sha512 checksum mismatch, expected Hq81Ata0vPJuzYeThT0w/m445aEUrhub9bXXGAkbx0komXkGNYHPWtzhN0dZKKKFlnGBcc0irfZ9ZeFezpj04A==, got GbsnNsI5HCS3kqSo99p2XTTtVT5aX3Lu1Gpk420fMEoxiveRpi+rnAHUh9+GqOnhgLev85Ntp8VJr017LjQHMw==
    at Object.newError (/Applications/Crypto.org Chain Desktop Wallet (Beta).app

@crypto-eddy
Copy link
Contributor Author

Issue 2

Possible blank screen as shown above when adding auto-updater hooks

@crypto-eddy
Copy link
Contributor Author

Issue 3

Related to issue 1 above, if we updater auto-updater to the latest version with fixes on hash mismatch we are likely going to run through a library incompatibility breaking change related to fs streams being used in later versions of the auto updater.

electron-userland/electron-builder#6000

@crypto-eddy
Copy link
Contributor Author

Progress

Updates events can now be logged, listened and passed to the render process, [WIP]

dc5cc25

Screen Shot 2021-07-07 at 1 09 45 PM

@crypto-eddy
Copy link
Contributor Author

PR available now for task 1 to 4 : #559

@crypto-eddy crypto-eddy added this to In progress in Project Board Jul 12, 2021
@crypto-eddy crypto-eddy moved this from In progress to QA in Project Board Jul 27, 2021
Project Board automation moved this from QA to Done Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants