From f5eae35b9c16d053c86c3c61d4ae1e4423ab8f15 Mon Sep 17 00:00:00 2001 From: Dan Hedgecock Date: Sat, 12 Sep 2020 17:45:02 -0700 Subject: [PATCH] =?UTF-8?q?Update:=20Disable=20import/no-unassigned-import?= =?UTF-8?q?s=20=E2=9A=99=EF=B8=8F=20(#244)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/__snapshots__/index.spec.js.snap | 4 ++-- src/rules/plugin-import.js | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/__snapshots__/index.spec.js.snap b/src/__snapshots__/index.spec.js.snap index cf81bab..0931d78 100644 --- a/src/__snapshots__/index.spec.js.snap +++ b/src/__snapshots__/index.spec.js.snap @@ -318,7 +318,7 @@ Object { "import/no-relative-parent-imports": "off", "import/no-restricted-paths": "off", "import/no-self-import": "error", - "import/no-unassigned-import": "error", + "import/no-unassigned-import": "off", "import/no-unresolved": Array [ "error", Object { @@ -1374,7 +1374,7 @@ Object { "import/no-relative-parent-imports": "off", "import/no-restricted-paths": "off", "import/no-self-import": "error", - "import/no-unassigned-import": "error", + "import/no-unassigned-import": "off", "import/no-unresolved": Array [ "error", Object { diff --git a/src/rules/plugin-import.js b/src/rules/plugin-import.js index e58613b..54a1a3c 100644 --- a/src/rules/plugin-import.js +++ b/src/rules/plugin-import.js @@ -180,9 +180,9 @@ module.exports = { // configure a useful number. 'import/max-dependencies': 'off', - // Prevents unassigned imports, this should be disabled as necessary in a codebase with - // an explanation of the side effect caused by the import - 'import/no-unassigned-import': 'error', + // Allow unassigned imports, it's surprisingly irritating to have to allow + // each occurence + 'import/no-unassigned-import': 'off', // Prevent importing the default as if it were named 'import/no-named-default': 'error',