Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crystal deps install should do a shallow clone #555

Closed
Arcnor opened this issue Apr 19, 2015 · 6 comments
Closed

crystal deps install should do a shallow clone #555

Arcnor opened this issue Apr 19, 2015 · 6 comments

Comments

@Arcnor
Copy link

Arcnor commented Apr 19, 2015

It doesn't seem that dependencies are cloned using shallow clones (at least the github ones). Unless there is a good reason not to, we don't need the full history of the repo when getting dependencies, do we?

@jhass
Copy link
Member

jhass commented Apr 19, 2015

With Git 1.9 this is indeed feasible. However prior to that shallow clones do not support fetch or pull, making updating them impossible.

@asterite
Copy link
Member

We can always clone again in the case of an update if shallow clones don't support fetch or pull.

@Arcnor
Copy link
Author

Arcnor commented Apr 22, 2015

Yes, I was thinking the same (but forgot to reply, it seems), although that
poses a problem if the repo itself is very big, but I'm guessing libraries
are going to be small and not full of resources?

On Thu, Apr 23, 2015 at 8:39 AM, Ary Borenszweig notifications@github.com
wrote:

We can always clone again in the case of an update if shallow clones don't
support fetch or pull.


Reply to this email directly or view it on GitHub
#555 (comment).

@ysbaddaden
Copy link
Contributor

I recently saw this commit for Bower that is related: bower/bower#1628

@jhass
Copy link
Member

jhass commented Sep 3, 2015

I think we can close this in favour of #1357 and/or a specific issue at https://github.com/ysbaddaden/shards too.

@asterite
Copy link
Member

asterite commented Sep 3, 2015

@jhass Definitely! Feel free to close any issues related to the package manager, the discussion can continue in #1357 or in shards itself.

@jhass jhass closed this as completed Sep 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants