fix(postcss-ordered-values): preserve columns count #1144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludofischer
commented
Jun 5, 2021
There was a problem hiding this comment.
We only want to do something when one value of the columns declaration has a unit (so is a width) and the other not. All other cases are either invalid or cannot be optimized through reordering. So the new code collects the widths and other types of values separately as it walks the tree, and reorders only if the condition holds at the end. If we stop as soon as two values are found, then we might make some invalid declarations valid and change the effect of the CSS.
| columns.walk((node) => { | ||
| const { type, value } = node; | ||
| if (type === 'word' && strValues.indexOf(value.toLowerCase())) { |
There was a problem hiding this comment.
I don't understand what the old code is trying to do. This seems a strange way to check if
value.toLowerCase() !== 'auto'(since it the only case where indexOf returns 0 )
Fix #1123 * rewrite columns handling logic * add tests
ludofischer
changed the title
alexander-akait
approved these changes
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1123