You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think we should order them before merge, and if reorder is failed (i.e. keeped) we just don't merge them, because I found our partial logic is rely on things which should not, for perf reason, we can reorder only potential to merge candidates
Describe the solution you would like
css-declaration-sorter should do it, even if developer disable use it directly, we can create fake root with required properties and sort them and then check it
@alexander-akait I have tried to move css-declaration-sorter before merge-rules but then the final output is not sorted anymore, so to preserve the sorting we would need to change something else or run css-declaration-sorter twice. What do you mean by
we can create fake root with required properties and sort them and then check it
? Did you end up implementing something similar in swc?
What should be improved?
.a { place-content: center; justify-content: start; } .b { justify-content: start; place-content: center; }
I think we should order them before merge, and if reorder is failed (i.e. keeped) we just don't merge them, because I found our partial logic is rely on things which should not, for perf reason, we can reorder only potential to merge candidates
Describe the solution you would like
css-declaration-sorter should do it, even if developer disable use it directly, we can create fake root with required properties and sort them and then check it
I think if we move it https://github.com/cssnano/cssnano/blob/master/packages/cssnano-preset-default/src/index.js#L124 before merge-rules we will fix most of cases
Possible alternatives
No response
Additional context
See the discussion in #1450
Are you willing to work on this?
The text was updated successfully, but these errors were encountered: