Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline eslint configuration? #635

Closed
jordrake opened this issue Oct 12, 2018 · 4 comments
Closed

Inline eslint configuration? #635

jordrake opened this issue Oct 12, 2018 · 4 comments

Comments

@jordrake
Copy link
Contributor

jordrake commented Oct 12, 2018

I noticed there are some inconsistencies across the packages (e.g. single and double quotes) and saw that this uses an external but specific eslint config located at https://github.com/ben-eb/eslint-config-cssnano.

I am assuming at one point this was because the packages used to be spread out across various repositories. Now this is no longer the case (I believe?) could we bring the eslint configuration inline either as a top-level .eslintrc or a packages/eslint-config-cssnano to make it easier to update.

Or just use a shared one.

@alexander-akait
Copy link
Member

alexander-akait commented Oct 12, 2018

@jordrake Yes, we need do it, also we should use prettier https://github.com/prettier/prettier for code style. I think we can avoid creating new package because we in monorepo. Feel free to send a PR.

Also will be great to switch from ava to jest with snapshot testing, he is faster and snapshot testing allow writing test very fast and very conveniently. Ava also have snahpshots, but the last time when i use their they were very unstable.

@jordrake
Copy link
Contributor Author

You'll get no argument from me on any of those fronts.

The conversion from jest to ava might be slightly painful as the tests rely a lot of ava's macro functionality but we could add a utility function which has the same signature or do something clever with codemods.

@alexander-akait
Copy link
Member

@jordrake yep, so migration from ava to jest is not high priority. We have other high priority bugs #411 #458 #535 (require more work). Any help welcome.

@andyjansson
Copy link
Contributor

#411 #458

These two I'll fix. Declaration sorting I haven't started on.

@alexander-akait alexander-akait added this to the 4.1 milestone Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants