You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed there are some inconsistencies across the packages (e.g. single and double quotes) and saw that this uses an external but specific eslint config located at https://github.com/ben-eb/eslint-config-cssnano.
I am assuming at one point this was because the packages used to be spread out across various repositories. Now this is no longer the case (I believe?) could we bring the eslint configuration inline either as a top-level .eslintrc or a packages/eslint-config-cssnano to make it easier to update.
Or just use a shared one.
The text was updated successfully, but these errors were encountered:
@jordrake Yes, we need do it, also we should use prettierhttps://github.com/prettier/prettier for code style. I think we can avoid creating new package because we in monorepo. Feel free to send a PR.
Also will be great to switch from ava to jest with snapshot testing, he is faster and snapshot testing allow writing test very fast and very conveniently. Ava also have snahpshots, but the last time when i use their they were very unstable.
You'll get no argument from me on any of those fronts.
The conversion from jest to ava might be slightly painful as the tests rely a lot of ava's macro functionality but we could add a utility function which has the same signature or do something clever with codemods.
@jordrake yep, so migration from ava to jest is not high priority. We have other high priority bugs #411#458#535 (require more work). Any help welcome.
I noticed there are some inconsistencies across the packages (e.g. single and double quotes) and saw that this uses an external but specific eslint config located at https://github.com/ben-eb/eslint-config-cssnano.
I am assuming at one point this was because the packages used to be spread out across various repositories. Now this is no longer the case (I believe?) could we bring the eslint configuration inline either as a top-level .eslintrc or a packages/eslint-config-cssnano to make it easier to update.
Or just use a shared one.
The text was updated successfully, but these errors were encountered: